build(proto): improve protobuf generation #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aceforeverd
commented
Nov 28, 2023
aceforeverd
commented
- tracking all generated files (.cpp, .h, .java), instead of .cpp file only
- auto clean all generated files on clean target, resolving build(clean): allow delete proto/swig generated files in project #891 for proto files
- simplify dependency in java modules, fixes build(proto java): generate to one module is sufficient #1090
- proto generated files to openmldb-common only, instead of multiple projects
- openmldb-native now depends on openmldb-common, no direct dependency to openmldb-common from other modules
github-actions
bot
added
build
aceforeverd
force-pushed
the
build-refresh-on-gen
branch
from
cde3a91 to
90aac56
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3636 +/- ##
============================================
- Coverage 74.97% 74.94% -0.04%
Complexity 640 640
============================================
Files 724 724
Lines 130359 130414 +55
Branches 1318 1325 +7
============================================
- Hits 97743 97739 -4
- Misses 32323 32382 +59
Partials 293 293 ☔ View full report in Codecov by Sentry. |
aceforeverd
requested review from
dl239,
vagetablechicken and
tobegit3hub
and removed request for
dl239 and
vagetablechicken
1. tracking all generated files (.cpp, .h, .java), instead of .cpp file only 2. auto clean all generated files on clean target, fix 4paradigm#891 for proto 3. simplify dependency in java modules, fix 4paradigm#1090 - proto generated files to openmldb-common only, instead of multiple projects - openmldb-native now depends on openmldb-common, no direct dependency to openmldb-common from other modules
aceforeverd
force-pushed
the
build-refresh-on-gen
branch
from
90aac56 to
d28332f
Compare
dl239
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.